Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comment INVALID_ADDRESS destroy -> disable #38

Merged
merged 1 commit into from Mar 9, 2019
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

@@ -100,7 +100,7 @@ contract Marmo {
address _signer = signer();

// The signer 'INVALID_ADDRESS' is considered invalid and it will always throw
// this is meant to destroy the wallet safely
// this is meant to disable the wallet safely
require(_signer != INVALID_ADDRESS, "Signer is not a valid address");

// Validate is the msg.sender is the signer or if the provided signature is valid
@@ -38,13 +38,13 @@ contract MarmoStork {
// Precalculate init_code hash
hash = keccak256(bytecode);

// Destroy the '_source' provided, if is not destroyed
// Destroy the '_source' provided, if is not disabled
Marmo marmoc = Marmo(_source);
if (marmoc.signer() == address(0)) {
marmoc.init(INVALID_ADDRESS);
}

// Validate, the signer of _source should be "INVALID_ADDRESS" (destroyed)
// Validate, the signer of _source should be "INVALID_ADDRESS" (disabled)
require(marmoc.signer() == INVALID_ADDRESS, "Error init Marmo source");

// Save the _source address, casting to address (160 bits)
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.