Catch possible error in reconnect() on _heartbeat(), emit reconnect error #1179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickewansmith
requested review from
FKSRipple and
intelliot
and removed request for
intelliot and
FKSRipple
FKSRipple
approved these changes
Jan 16, 2020
|
@FKSRipple , not sure of your release schedule. I'm wondering when the next release would be? |
|
We don't have a particular schedule and can do a release anytime one is warranted. It tends to be every 1-3 weeks but I can go ahead and do a release later today. |
nickewansmith
deleted the
fix-unhandled-rejection-warning-on-heartbeat
branch
|
ripple-lib 1.6.2 released ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses a possible uncaught error on run of
this._heartbeatand subsequentlythis.reconnect()as the reconnection promise could throw.Emits an error event if
this.reconnect()does throw as seen in other reconnect failures.