Skip to content
Permalink
Branch: develop
Commits on Jun 14, 2019
  1. Set version to 1.3.0-b5

    manojsdoshi committed Jun 14, 2019
  2. Force snappy compression for RocksDB (remove option):

    mellery451 authored and manojsdoshi committed May 13, 2019
    FIXES: #2860
    
     * Also remove RocksDBQuick backend which is non-functional.
  3. Modernize base_uint:

    HowardHinnant authored and manojsdoshi committed May 23, 2019
    *  Add construction and assignment from a generic
       contiguous container.  Both compile-time and run time
       safety checks are made to ensure the safety of this
       conversion.
    
    *  Remove base_uint::copyFrom.  The generic copy assignment
       operator now does this functionality with enhanced
       safety and better syntax.
    
    *  Remove construction from and dedendence on Blob.
       The generic constructor and assignment now handle this
       functionality.
    
    *  Fix client code to adhere to this new API.
    
    *  Removed the use of fromVoid in PeerImp.cpp as it was
       an inappropriate use of this dangerous API.  The
       generic container constructors do it with enhanced
       safety and better syntax.
    
    *  Rename data member pn to data_ and make it private.
    
    *  Remove constraint from hash_append
    
    *  Remove array_type alias
  4. Fix SNTPClock shutdown

    miguelportilla authored and manojsdoshi committed May 24, 2019
    This PR addresses a problem where the server could hang indefinitely
    on shutdown. The cause of the problem is the SNTPClock class was not
    binding the socket to an endpoint on initialization. This can create
    an error sent to the read handler. Unfortunately, the handler ignores
    the error, reads again and enters into a loop preventing the
    io_service from ever completing.
Commits on May 22, 2019
  1. Set version to 1.3.0-b4

    manojsdoshi committed May 21, 2019
  2. Document IPv6 usage in sample config:

    invalidator authored and manojsdoshi committed Feb 24, 2019
    - Explain how to bind to both IPv4 and IPv6 interfaces
    - Provide a hint in the default [port_peer] section
    - Do not enable it by default
    
    Note that on Linux, use of '::' and IPv4-mapped IPv6 depends on a sysctl value
    setting 'net.ipv6.bindv6only = 0' which seems to be the default on most Linux
    distributions.
  3. Improve locking:

    HowardHinnant authored and manojsdoshi committed Apr 18, 2019
    - Use `std::lock` when grabbing multiple mutexes to ensure consistent
    locking order and avoid deadlocks.
    - Reduce the scope of the master mutex lock by relesing it prior to
    calling setHeartbeatTimer
  4. Make some locks more granular:

    JoelKatz authored and manojsdoshi committed Apr 18, 2019
    - Overlay
    - Cluster
    - Validator List
    - Consensus
    
    The overlay also has its own lock and manages its own thread safety.
  5. Pause for lagging validators.

    mtrippled authored and manojsdoshi committed Feb 21, 2019
Commits on May 20, 2019
  1. Payment paths with a zero output step are dry (RIPD-1749):

    seelabs authored and manojsdoshi committed May 9, 2019
    A tiny input amount to a payment step can cause this step to output zero. For
    example, if a previous steps outputs a dust amount of 10^-80, and this step is a
    IOU -> XRP offer, the offer may output zero drops. In this case, call the strand
    dry. Before this patch, an error would be logged, the strand would be called
    dry; in debug mode an assert triggered.
    
    Note, this patch is not transaction breaking, as the caller did not user the ter
    code. The caller only checked for success or failuer.
    
    This patch addresses github issue issue reported here:
    #2929
  2. Support Boost 1.70:

    seelabs authored and manojsdoshi committed Apr 12, 2019
    This patch removes calls to several deprecated asio functions.
    
    * `io_service::post` becomes `post` (free function)
    * `io_service::work` becomes `executor_work_guard`
    * `io_service::wrap` becomes `bind_executor`
    * `get_io_context`   becomes `get_executor` or `get_executor().context()`
    
    This patch was tested with boost 1.69 and 1.70. The functions
    `ripple::get_lowest_layer` and `beast::create_waitable_timer` are required to
    handle a breaking difference between these versions. When rippled no longer
    needs to support pre 1.70 boost versions, both of these functions may be
    removed, and the waitable timer injections may also be removed.
  3. Add some missing items to help command list:

    ximinez authored and manojsdoshi committed May 15, 2019
    * validators
    * validator_list_sites
    * Put "version" in the right place
  4. Configure build+test matrix for GitLab CI:

    thejohnfreeman authored and manojsdoshi committed Mar 28, 2019
    * Disable parallel tests for address sanitizer
    * Improve caching
    * Prefer Ninja builds because they are faster
  5. Refine parseUrl regular expression (RIPD-1708):

    thejohnfreeman authored and manojsdoshi committed Feb 18, 2019
    The new parse logic is more strict but handles more cases. If an exception
    is thrown, just bail.
    
    * Allow parsing unenclosed IPv6 addresses without port
    * Improve string construction
    * Reduce nesting levels of code
Commits on Apr 29, 2019
  1. Set version to 1.3.0-b3

    seelabs committed Apr 29, 2019
  2. Disallow using the master key as the regular key:

    thejohnfreeman authored and seelabs committed Mar 5, 2019
    The XRP Ledger allows an account to authorize a secondary key pair,
    called a regular key pair, to sign future transactions, while keeping
    the master key pair offline.
    
    The regular key pair can be changed as often as desired, without
    requiring other changes on the account.
    
    If merged, this commit corrects a minor technical flaw which would
    allow an account holder to specify the master key as the account's
    new regular key.
    
    The change is controlled by the `fixMasterKeyAsRegularKey` amendment
    which, if enabled, will:
    
    1. Prevent specifying an account's master key as the account's
       regular key.
    2. Prevent the "Disable Master Key" flag from incorrectly affecting
       regular keys.
  3. Request RocksDB PORTABLE build option

    mellery451 authored and seelabs committed Apr 25, 2019
  4. Improvements to pkg CI pipeline:

    mellery451 authored and seelabs committed Mar 27, 2019
    * add manual approval option before push to prod
    * Use new public repo DNS name
    * add distros to smoketest
  5. Improve jemalloc build config:

    mellery451 authored and seelabs committed Mar 6, 2019
    * fix include order for macos/homebrew
    * use static jemalloc for static builds
    * set CMP0074 for using <pkgname>_ROOT variables
  6. Improve windows build README

    mellery451 authored and seelabs committed Apr 3, 2019
Commits on Apr 26, 2019
  1. Arguments passed to jtx Env::operator() must be invocable:

    seelabs authored and nbougalis committed Mar 23, 2019
    Before this patch, jtx allowed non-invocable functions to be passed to
    operator(). However, these arguments are ignored. This caused erronious code
    code such as:
    
    ```
    env (offer (account_to_test, BTC (250), XRP (1000)),
             offers (account_to_test, 1));
    ```
    
    While it looks like the number of offers are checked, they are not. The `offers`
    funclet is never run. While we could modify jtx to make the above code correct,
    a cleaner solution is to run post conditions in a `require` statement after a
    transasction runs.
Older
You can’t perform that action at this time.