Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed 0.40.0-b6 #1860

merged 17 commits into from Sep 30, 2016


None yet
7 participants
Copy link

nbougalis commented Sep 29, 2016

Merge master & release into develop, and merge PRs #1841, #1846, #1850, #1851, #1856, and #1858.

seelabs and others added some commits Sep 13, 2016

Add Status page:
* Make HTTP(S) requests on websocket ports reply with Status page
* Fix isWebsocketUpgrade to compare case insensitive
* Make websocket upgrades with no websocket protocols configured report error
* Create unit test for unauthorized requets and the status page
add the support script:
The script can be used to quickly and easily retrieve
information to assess the health of a rippled server

This comment has been minimized.

Copy link

codecov-io commented Sep 29, 2016

Current coverage is 64.41% (diff: 100%)

Merging #1860 into develop will decrease coverage by 0.32%

@@            develop      #1860   diff @@
  Files           704        683     -21   
  Lines         50790      48973   -1817   
  Methods           0          0           
  Messages          0          0           
  Branches          0          0           
- Hits          32884      31546   -1338   
+ Misses        17906      17427    -479   
  Partials          0          0           

Powered by Codecov. Last update 231a5ae...a7630aa

@nbougalis nbougalis changed the title Merge release into develop Proposed 0.40.0-b5 Sep 29, 2016

vinniefalco and others added some commits Sep 29, 2016

Squashed 'src/nudb/' content from commit 00adc6a
git-subtree-dir: src/nudb
git-subtree-split: 00adc6a4f16679a376f40c967f77dfa544c179c1
Fix unfunded offer not removed (RIPD-1298):
If the mantissas of two non-native amounts differ by less than 10, then
subtracting them leaves a result of zero. This can cause situations
where `a>b`, yet `a-b == 0`.

One consequence of this is unfunded offers were incorrectly left in
order books. The code would check if the offer would be
consumed (`amount in offer > amount needed`), assume it wouldn't be,
yet when `amount needed` was subtracted from `amount in offer` the
result was zero and the offer was unfunded. This unfunded offer
incorrectly remained on the order book.

This patch fixes this bug.
Add book_offers RPC tests (RIPD-1283):
Migrate orderbook-test.js to cpp tests. Provide
coverage for error conditions in book_offers
RPC method.
Prepare for boost 1.62
These changes are compatible with previous boost releases.
Improve Buffer and Slice:
* Make Buffer constructible from a Slice
* Fix self-move-assignment in Buffer
* Add unit tests

@nbougalis nbougalis changed the title Proposed 0.40.0-b5 Proposed 0.40.0-b6 Sep 30, 2016

@nbougalis nbougalis merged commit a7630aa into ripple:develop Sep 30, 2016

5 checks passed

ci/circleci Your tests passed on CircleCI!
codecov/patch 100% of diff hit (target 64.74%)
codecov/project Absolute coverage decreased by -0.32% but relative coverage increased by +35.25% compared to 231a5ae
continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.