Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly parse multi-buffer JSON messages (RIPD-1306) #1862

Merged
merged 3 commits into from Oct 2, 2016

Conversation

Projects
None yet
5 participants
@nbougalis
Copy link
Member

commented Oct 1, 2016

No description provided.

@vinniefalco

This comment has been minimized.

Copy link
Contributor

commented Oct 1, 2016

👍

ximinez and others added some commits Oct 1, 2016

Correctly parse multi-buffer JSON messages (RIPD-1306):
When attempting to parse a BufferSequence as a JSON object,
if the sequence contained more than buffer, the JSON parser
would incorrectly attempt to decode each buffer as a separate
JSON object, instead of one complete object.
@codecov-io

This comment has been minimized.

Copy link

commented Oct 2, 2016

Current coverage is 64.42% (diff: 100%)

Merging #1862 into develop will increase coverage by <.01%

@@            develop      #1862   diff @@
==========================================
  Files           683        683          
  Lines         48973      48973          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          31549      31553     +4   
+ Misses        17424      17420     -4   
  Partials          0          0          

Powered by Codecov. Last update a7630aa...aa11eff

@nbougalis nbougalis merged commit aa11eff into ripple:develop Oct 2, 2016

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 64.42%)
Details
codecov/project 64.42% (+<.01%) compared to a7630aa
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@nbougalis nbougalis deleted the nbougalis:jsonInvalid branch Oct 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.