Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant call to clearNeedNetworkLedger #1931

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@lieefu
Copy link
Contributor

lieefu commented Dec 8, 2016

if (consensus)
{
  clearNeedNetworkLedger ();//_first run_--------------------------------

    // FIXME: If this rewinds the ledger sequence, or has the same sequence, we
    // should update the status on any stored transactions in the invalidated
    // ledgers.
    switchLastClosedLedger (consensus);//double run in this function --------
}
return true;

void NetworkOPsImp::switchLastClosedLedger (
std::shared_ptr const& newLCL)
{
clearNeedNetworkLedger ();//double run -----------------------------------

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Dec 8, 2016

Current coverage is 65.44% (diff: 100%)

Merging #1931 into develop will decrease coverage by 0.01%

@@            develop      #1931   diff @@
==========================================
  Files           698        698          
  Lines         49745      49744     -1   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits          32562      32556     -6   
- Misses        17183      17188     +5   
  Partials          0          0          

Powered by Codecov. Last update 4d7b1a3...e0033b8

@nbougalis

This comment has been minimized.

Copy link
Member

nbougalis commented Dec 8, 2016

Thanks for your contribution! I would prefer a rewording of the commit message: Remove redundant call to clearNeedNetworkLedger but we can do that during merge.

@lieefu lieefu changed the title remove a double run sentence clearNeedNetworkLedger (); Remove redundant call to clearNeedNetworkLedger Dec 8, 2016

Remove redundant call to clearNeedNetworkLedger
if (consensus)
{
  clearNeedNetworkLedger ();//_first run_--------------------------------

    // FIXME: If this rewinds the ledger sequence, or has the same sequence, we
    // should update the status on any stored transactions in the invalidated
    // ledgers.
    switchLastClosedLedger (consensus);//double run in this function --------
}
return true;
void NetworkOPsImp::switchLastClosedLedger (
std::shared_ptr const& newLCL)
{
clearNeedNetworkLedger ();//double run -----------------------------------

@lieefu lieefu force-pushed the lieefu:remove_double_run_sentence branch from a29b104 to e0033b8 Dec 8, 2016

@JoelKatz

This comment has been minimized.

Copy link
Member

JoelKatz commented Dec 12, 2016

👍

@nbougalis nbougalis added the Passed label Dec 16, 2016

@nbougalis

This comment has been minimized.

Copy link
Member

nbougalis commented Dec 25, 2016

Merged as 7ff243a. Thank you for your contribution.

@nbougalis nbougalis closed this Dec 25, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.