Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ledger_current_index to fee RPC result (RIPD-1300) #1949

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
5 participants
@ximinez
Copy link
Contributor

commented Dec 28, 2016

Nearly trivial.

Example updated output of the fee RPC command:

{
   "id" : 1,
   "result" : {
      "current_ledger_size" : "16",
      "current_queue_size" : "14",
      "drops" : {
         "base_fee" : "10",
         "median_fee" : "5000",
         "minimum_fee" : "10",
         "open_ledger_fee" : "51200"
      },
      "expected_ledger_size" : "5",
      "ledger_current_index" : 26575101,
      "levels" : {
         "median_level" : "128000",
         "minimum_level" : "256",
         "open_ledger_level" : "1310720",
         "reference_level" : "256"
      },
      "max_queue_size" : "100",
      "status" : "success"
   }
}

No documentation preview, because no .h files were touched.

@ximinez ximinez requested review from bachase and scottschurr Dec 28, 2016

@bachase

This comment has been minimized.

Copy link
Contributor

commented Dec 28, 2016

👍

Any API documentation need updating?

@codecov-io

This comment has been minimized.

Copy link

commented Dec 28, 2016

Current coverage is 66.51% (diff: 100%)

Merging #1949 into develop will decrease coverage by <.01%

@@            develop      #1949   diff @@
==========================================
  Files           687        687          
  Lines         49314      49315     +1   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits          32801      32801          
- Misses        16513      16514     +1   
  Partials          0          0          

Powered by Codecov. Last update 87273e2...36e3890

@scottschurr

This comment has been minimized.

Copy link
Contributor

commented Jan 2, 2017

👍 Looks reasonable to me.

@ximinez ximinez added the Passed label Jan 3, 2017

@ximinez ximinez force-pushed the ximinez:fee_ripd1300 branch from a94da74 to b33fdd2 Jan 3, 2017

@ximinez ximinez force-pushed the ximinez:fee_ripd1300 branch from b33fdd2 to 36e3890 Jan 10, 2017

@nbougalis

This comment has been minimized.

Copy link
Member

commented Jan 14, 2017

Merged as 1989b10.

@nbougalis nbougalis closed this Jan 14, 2017

@ximinez ximinez deleted the ximinez:fee_ripd1300 branch Jan 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.