Join GitHub today
0.60.0-b1 with updated libsecp256k1 and beast b24 #1983
This brings the secp256k1 subtree up to the tip of the master branch in the upstream repository (https://github.com/bitcoin-core/secp256k1)
The review needs to provide special attention to the treatment of non-canonical signatures. In particular we need to know whether or not calls to
Additionally, the beast subtree is brought up to 1.0.0-b24 which includes support for the permessage-deflate extension (defaulting to off). There should be no behavioral changes in rippled.
@@ Coverage Diff @@ ## develop #1983 +/- ## ========================================== - Coverage 67.31% 67.12% -0.2% ========================================== Files 686 686 Lines 49320 49329 +9 ========================================== - Hits 33201 33111 -90 - Misses 16119 16218 +99
Latest snappy release (https://github.com/google/snappy) also claims some performance improvements and the protobuf library included in rippled is also getting a bit dusty. SOCI doesn't seem to have had releases since 2015 and most commits seem to be around adding tests and tooling, not fixing security bugs.
https://github.com/open-source-parsers/jsoncpp is also used but not included as subtree, I don't know how much of the upstream code is even left in rippled.
LZ4 might also profit from an update, though I'm not so sure where LZ4 is used in rippled. In case you want to look at updating compression libraries, evaluating zstd (https://github.com/facebook/zstd) might be interesting too, as well as checking out Zopfli and Brotli by Google. Apparently the series "Silicon Valley" created a bit of interest in compression technologies.