New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests of RPC "sign" #2010

Closed
wants to merge 1 commit into
base: develop
from

Conversation

Projects
None yet
5 participants
@ximinez
Contributor

ximinez commented Feb 10, 2017

Specifically to demonstrate that #229 is resolved.

@vinniefalco

This comment has been minimized.

Show comment
Hide comment
@vinniefalco

vinniefalco Feb 10, 2017

Contributor

Suggested commit message:

Add more 'sign' tests:

fix #229

If you use this verbatim, GitHub will close the issue automatically when the branch is merged.

Contributor

vinniefalco commented Feb 10, 2017

Suggested commit message:

Add more 'sign' tests:

fix #229

If you use this verbatim, GitHub will close the issue automatically when the branch is merged.

@mellery451

👍

Show outdated Hide outdated src/test/rpc/JSONRPC_test.cpp
Show outdated Hide outdated src/test/rpc/JSONRPC_test.cpp
@ximinez

This comment has been minimized.

Show comment
Hide comment
@ximinez

ximinez Feb 10, 2017

Contributor

I just rewrote history to change the commit message, but the first commit is otherwise unchanged.

Contributor

ximinez commented Feb 10, 2017

I just rewrote history to change the commit message, but the first commit is otherwise unchanged.

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Feb 10, 2017

Codecov Report

Merging #2010 into develop will decrease coverage by -0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #2010      +/-   ##
===========================================
- Coverage    67.25%   67.25%   -0.01%     
===========================================
  Files          683      683              
  Lines        49231    49231              
===========================================
- Hits         33112    33111       -1     
- Misses       16119    16120       +1
Impacted Files Coverage Δ
src/ripple/app/ledger/impl/LedgerMaster.cpp 44.41% <ø> (-0.23%)
src/ripple/server/impl/BaseWSPeer.h 78.33% <ø> (+0.83%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 460dd8f...64838d9. Read the comment docs.

codecov-io commented Feb 10, 2017

Codecov Report

Merging #2010 into develop will decrease coverage by -0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #2010      +/-   ##
===========================================
- Coverage    67.25%   67.25%   -0.01%     
===========================================
  Files          683      683              
  Lines        49231    49231              
===========================================
- Hits         33112    33111       -1     
- Misses       16119    16120       +1
Impacted Files Coverage Δ
src/ripple/app/ledger/impl/LedgerMaster.cpp 44.41% <ø> (-0.23%)
src/ripple/server/impl/BaseWSPeer.h 78.33% <ø> (+0.83%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 460dd8f...64838d9. Read the comment docs.

@vinniefalco

love it

@ximinez ximinez added the Passed label Feb 23, 2017

@ximinez

This comment has been minimized.

Show comment
Hide comment
@ximinez

ximinez Feb 23, 2017

Contributor

Squashed

Contributor

ximinez commented Feb 23, 2017

Squashed

@seelabs

This comment has been minimized.

Show comment
Hide comment
@seelabs

seelabs Mar 1, 2017

Contributor

In 0.60.0-b7

Contributor

seelabs commented Mar 1, 2017

In 0.60.0-b7

@seelabs seelabs closed this Mar 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment