Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "wss" work the same as "wss2" #2033

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@JoelKatz
Copy link
Member

commented Feb 28, 2017

This is develop branch version of the patch applied to 0.50 to make sure "wss" and "wss2" work the same in the config. This fixes a bug reported in the forum.

@vinniefalco vinniefalco requested review from vinniefalco and mellery451 Mar 1, 2017

@mellery451
Copy link
Contributor

left a comment

I'm disappointed I missed this in the commit that merged wss and wss2 - thanks for fixing it.

@vinniefalco

This comment has been minimized.

Copy link
Contributor

commented Mar 2, 2017

@mellery451 if code never had bugs we'd be out of a job!

@vinniefalco vinniefalco added the Passed label Mar 6, 2017

@seelabs

This comment has been minimized.

Copy link
Contributor

commented Mar 6, 2017

In 0.60.0-rc1

@seelabs seelabs closed this Mar 6, 2017

@JoelKatz JoelKatz deleted the JoelKatz:ws_fix branch Oct 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.