New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce rippling constraints during payments #2049

Closed
wants to merge 2 commits into
base: develop
from

Conversation

Projects
None yet
5 participants
@seelabs
Contributor

seelabs commented Mar 13, 2017

No description provided.

@HowardHinnant

This comment has been minimized.

Show comment
Hide comment
@HowardHinnant

HowardHinnant Mar 13, 2017

Contributor

Should this not be built on top of 0.60.0-rc3, and re-tagged? It is currently built on rc2 which bypasses ffc7cf8 .

Contributor

HowardHinnant commented Mar 13, 2017

Should this not be built on top of 0.60.0-rc3, and re-tagged? It is currently built on rc2 which bypasses ffc7cf8 .

@seelabs

This comment has been minimized.

Show comment
Hide comment
@seelabs

seelabs Mar 13, 2017

Contributor

@HowardHinnant Good catch. Yes, this should be on top of rc3. Will fix.

Contributor

seelabs commented Mar 13, 2017

@HowardHinnant Good catch. Yes, this should be on top of rc3. Will fix.

@seelabs

This comment has been minimized.

Show comment
Hide comment
@seelabs

seelabs Mar 13, 2017

Contributor

rebased onto 0.60.0-rc3 and force pushed

Contributor

seelabs commented Mar 13, 2017

rebased onto 0.60.0-rc3 and force pushed

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Mar 13, 2017

Codecov Report

Merging #2049 into develop will increase coverage by 0.01%.
The diff coverage is 93.33%.

@@             Coverage Diff             @@
##           develop    #2049      +/-   ##
===========================================
+ Coverage    67.67%   67.69%   +0.01%     
===========================================
  Files          680      680              
  Lines        49204    49219      +15     
===========================================
+ Hits         33299    33318      +19     
+ Misses       15905    15901       -4
Impacted Files Coverage Δ
src/ripple/ledger/View.h 100% <ø> (ø)
src/ripple/ledger/impl/View.cpp 89.36% <100%> (+1.37%)
src/ripple/app/paths/impl/BookStep.cpp 85.76% <90.9%> (+0.2%)
src/ripple/beast/clock/chrono_util.h 82.6% <0%> (-8.7%)
src/ripple/basics/DecayingSample.h 77.77% <0%> (-8.34%)
src/ripple/beast/core/WaitableEvent.cpp 87.75% <0%> (-4.09%)
src/ripple/server/impl/BaseWSPeer.h 77.5% <0%> (-3.34%)
src/ripple/core/impl/Stoppable.cpp 92.55% <0%> (-3.2%)
src/ripple/beast/asio/io_latency_probe.h 97.01% <0%> (-1.5%)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cea5d0...668b6f2. Read the comment docs.

codecov-io commented Mar 13, 2017

Codecov Report

Merging #2049 into develop will increase coverage by 0.01%.
The diff coverage is 93.33%.

@@             Coverage Diff             @@
##           develop    #2049      +/-   ##
===========================================
+ Coverage    67.67%   67.69%   +0.01%     
===========================================
  Files          680      680              
  Lines        49204    49219      +15     
===========================================
+ Hits         33299    33318      +19     
+ Misses       15905    15901       -4
Impacted Files Coverage Δ
src/ripple/ledger/View.h 100% <ø> (ø)
src/ripple/ledger/impl/View.cpp 89.36% <100%> (+1.37%)
src/ripple/app/paths/impl/BookStep.cpp 85.76% <90.9%> (+0.2%)
src/ripple/beast/clock/chrono_util.h 82.6% <0%> (-8.7%)
src/ripple/basics/DecayingSample.h 77.77% <0%> (-8.34%)
src/ripple/beast/core/WaitableEvent.cpp 87.75% <0%> (-4.09%)
src/ripple/server/impl/BaseWSPeer.h 77.5% <0%> (-3.34%)
src/ripple/core/impl/Stoppable.cpp 92.55% <0%> (-3.2%)
src/ripple/beast/asio/io_latency_probe.h 97.01% <0%> (-1.5%)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cea5d0...668b6f2. Read the comment docs.

@seelabs

This comment has been minimized.

Show comment
Hide comment
@seelabs

seelabs Mar 14, 2017

Contributor

In 0.60.0-rc4

Contributor

seelabs commented Mar 14, 2017

In 0.60.0-rc4

@seelabs seelabs closed this Mar 14, 2017

@seelabs seelabs deleted the seelabs:no-ripple branch Jul 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment