New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ledger and manifest Python tools #2057

Closed
wants to merge 1 commit into
base: develop
from

Conversation

Projects
None yet
5 participants
@wilsonianb

wilsonianb commented Mar 16, 2017

The ledger tool is unused, and the manifest tool has been replaced by https://github.com/wilsonianb/validator-keys-tool
These will be moved to their own repo in the ripple-unmaintained org
https://github.com/wilsonianb/ripple-python-tools

wilsonianb
@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Mar 17, 2017

Codecov Report

Merging #2057 into develop will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #2057      +/-   ##
===========================================
- Coverage     67.7%   67.69%   -0.02%     
===========================================
  Files          680      680              
  Lines        49219    49219              
===========================================
- Hits         33323    33318       -5     
- Misses       15896    15901       +5
Impacted Files Coverage Δ
src/ripple/basics/DecayingSample.h 77.77% <0%> (-8.34%)
src/ripple/beast/asio/io_latency_probe.h 97.01% <0%> (-1.5%)
src/ripple/core/impl/JobQueue.cpp 86.11% <0%> (-0.47%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0df1b09...7cd025f. Read the comment docs.

codecov-io commented Mar 17, 2017

Codecov Report

Merging #2057 into develop will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #2057      +/-   ##
===========================================
- Coverage     67.7%   67.69%   -0.02%     
===========================================
  Files          680      680              
  Lines        49219    49219              
===========================================
- Hits         33323    33318       -5     
- Misses       15896    15901       +5
Impacted Files Coverage Δ
src/ripple/basics/DecayingSample.h 77.77% <0%> (-8.34%)
src/ripple/beast/asio/io_latency_probe.h 97.01% <0%> (-1.5%)
src/ripple/core/impl/JobQueue.cpp 86.11% <0%> (-0.47%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0df1b09...7cd025f. Read the comment docs.

@nbougalis

👍 but one question: will the new tools be hosted on your personal GitHub, or under Ripple's main repo?

@wilsonianb

This comment has been minimized.

Show comment
Hide comment
@wilsonianb

wilsonianb Mar 17, 2017

They will be hosted on this repo:
https://github.com/ripple-unmaintained
Sorry, new tool is already in Ripple org
https://github.com/ripple/validator-keys-tool

wilsonianb commented Mar 17, 2017

They will be hosted on this repo:
https://github.com/ripple-unmaintained
Sorry, new tool is already in Ripple org
https://github.com/ripple/validator-keys-tool

@seelabs

This comment has been minimized.

Show comment
Hide comment
@seelabs

seelabs Mar 17, 2017

Contributor

👍

Contributor

seelabs commented Mar 17, 2017

👍

@seelabs seelabs added the Passed label Mar 17, 2017

@scottschurr scottschurr referenced this pull request Mar 21, 2017

Merged

Develop next #2059

@scottschurr

This comment has been minimized.

Show comment
Hide comment
@scottschurr

scottschurr Mar 21, 2017

Contributor

Merged to develop as fc0d64f

Contributor

scottschurr commented Mar 21, 2017

Merged to develop as fc0d64f

@wilsonianb wilsonianb deleted the wilsonianb:rm-python-tools branch May 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment