Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct bit width for spaceEscrow and spaceXRPUChannels when hashing #2071

Closed
wants to merge 1 commit into from

Conversation

seelabs
Copy link
Collaborator

@seelabs seelabs commented Mar 29, 2017

No description provided.

Copy link
Contributor

@wilsonianb wilsonianb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
especially with commit message in
#2072

@seelabs seelabs added the Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required. label Mar 29, 2017
@codecov-io
Copy link

Codecov Report

Merging #2071 into develop will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2071      +/-   ##
===========================================
- Coverage    68.54%   68.53%   -0.01%     
===========================================
  Files          679      679              
  Lines        49554    49554              
===========================================
- Hits         33965    33962       -3     
- Misses       15589    15592       +3
Impacted Files Coverage Δ
src/ripple/protocol/impl/Indexes.cpp 92.63% <100%> (ø) ⬆️
src/ripple/basics/DecayingSample.h 77.77% <0%> (-8.34%) ⬇️
src/ripple/beast/asio/io_latency_probe.h 97.01% <0%> (-1.5%) ⬇️
src/ripple/app/tx/impl/PayChan.cpp 91.7% <0%> (-0.49%) ⬇️
src/ripple/app/ledger/impl/LedgerMaster.cpp 44.26% <0%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbe74df...50772a1. Read the comment docs.

@nbougalis nbougalis closed this Mar 30, 2017
@seelabs seelabs deleted the hash-space branch July 13, 2017 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants