New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grow TxQ expected size quickly, shrink slowly (RIPD-1534): #2235

Closed
wants to merge 1 commit into
base: develop
from

Conversation

Projects
None yet
5 participants
@ximinez
Contributor

ximinez commented Sep 27, 2017

  • Stores recent history of "good" ledgers. Uses the maximum as the
    expected ledger size. When a large value drops off, use a 90%
    backoff to go down to to the new maximum.
  • If consensus is unhealthy, wipe the history in addition to the current
    clamping.
  • Include .md doc files in xcode and VS projects

Open question: Does this need to be behind an amendment? I don't think so because it only affects transaction queueing, not transaction processing, just as 0.70.2 didn't need an amendment.

Show outdated Hide outdated src/ripple/app/misc/impl/TxQ.cpp
@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Oct 2, 2017

Codecov Report

Merging #2235 into develop will increase coverage by <.01%.
The diff coverage is 92.3%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2235      +/-   ##
===========================================
+ Coverage    70.11%   70.11%   +<.01%     
===========================================
  Files          689      689              
  Lines        50800    50810      +10     
===========================================
+ Hits         35617    35626       +9     
- Misses       15183    15184       +1
Impacted Files Coverage Δ
src/ripple/app/misc/TxQ.h 96.77% <100%> (+0.1%) ⬆️
src/ripple/app/misc/NetworkOPs.cpp 61.74% <100%> (ø) ⬆️
src/ripple/app/misc/impl/TxQ.cpp 95.85% <90.9%> (-0.1%) ⬇️
src/ripple/app/misc/SHAMapStoreImp.cpp 78.92% <0%> (-1.03%) ⬇️
src/ripple/protocol/impl/Serializer.cpp 70.3% <0%> (+0.34%) ⬆️
src/ripple/protocol/impl/STVar.cpp 88.31% <0%> (+2.59%) ⬆️
src/ripple/core/Stoppable.h 100% <0%> (+6.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cafe18c...de3805f. Read the comment docs.

codecov-io commented Oct 2, 2017

Codecov Report

Merging #2235 into develop will increase coverage by <.01%.
The diff coverage is 92.3%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2235      +/-   ##
===========================================
+ Coverage    70.11%   70.11%   +<.01%     
===========================================
  Files          689      689              
  Lines        50800    50810      +10     
===========================================
+ Hits         35617    35626       +9     
- Misses       15183    15184       +1
Impacted Files Coverage Δ
src/ripple/app/misc/TxQ.h 96.77% <100%> (+0.1%) ⬆️
src/ripple/app/misc/NetworkOPs.cpp 61.74% <100%> (ø) ⬆️
src/ripple/app/misc/impl/TxQ.cpp 95.85% <90.9%> (-0.1%) ⬇️
src/ripple/app/misc/SHAMapStoreImp.cpp 78.92% <0%> (-1.03%) ⬇️
src/ripple/protocol/impl/Serializer.cpp 70.3% <0%> (+0.34%) ⬆️
src/ripple/protocol/impl/STVar.cpp 88.31% <0%> (+2.59%) ⬆️
src/ripple/core/Stoppable.h 100% <0%> (+6.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cafe18c...de3805f. Read the comment docs.

@nbougalis

Tentative approve from me; I've left a couple of small comments for your consideration. No changes needed really; it's at your discretion.

Show outdated Hide outdated src/ripple/app/misc/impl/TxQ.cpp
Show outdated Hide outdated src/ripple/app/misc/impl/TxQ.cpp
Show outdated Hide outdated src/ripple/app/misc/impl/TxQ.cpp
Grow TxQ expected size quickly, shrink slowly (RIPD-1534):
* Stores recent history of "good" ledgers. Uses the maximum as the
  expected ledger size. When a large value drops off, use a 90%
  backoff to go down to to the new maximum.
* If consensus is unhealthy, wipe the history in addition to the current
  clamping.
* Include .md doc files in xcode and VS projects

@ximinez ximinez added the Passed label Nov 11, 2017

@bachase

This comment has been minimized.

Show comment
Hide comment
@bachase

bachase Nov 30, 2017

Contributor

Merged as c11e186

Contributor

bachase commented Nov 30, 2017

Merged as c11e186

@bachase bachase closed this Nov 30, 2017

@ximinez ximinez deleted the ximinez:txqtarget branch Nov 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment