New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include validator manifests in published list: #2278

Merged
merged 1 commit into from Nov 30, 2017

Conversation

Projects
None yet
4 participants
@wilsonianb

wilsonianb commented Nov 22, 2017

Manifests of validators newly added to a published validator list are
not reliably propagated to network nodes.
This solves the problem by allowing a published validator list to
include the manifest.

RIPD-1559

This will need to be reconciled with the test changes in #2242

wilsonianb
Include validator manifests in published list:
Manifests of validators newly added to a published validator list are
not reliably propagated to network nodes.
This solves the problem by allowing a published validator list to
include the manifest.

RIPD-1559
@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Nov 22, 2017

Codecov Report

Merging #2278 into develop will decrease coverage by <.01%.
The diff coverage is 53.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #2278      +/-   ##
==========================================
- Coverage    70.11%   70.1%   -0.01%     
==========================================
  Files          689     689              
  Lines        50800   50815      +15     
==========================================
+ Hits         35617   35626       +9     
- Misses       15183   15189       +6
Impacted Files Coverage Δ
src/ripple/app/misc/ValidatorList.h 98.27% <ø> (ø) ⬆️
src/ripple/app/misc/ValidatorSite.h 100% <ø> (ø) ⬆️
src/ripple/app/misc/impl/ValidatorList.cpp 81.22% <53.33%> (-2.12%) ⬇️
src/ripple/app/main/Application.cpp 60.42% <0%> (-0.12%) ⬇️
src/ripple/protocol/impl/STVar.cpp 88.31% <0%> (+2.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cafe18c...bce9bca. Read the comment docs.

codecov-io commented Nov 22, 2017

Codecov Report

Merging #2278 into develop will decrease coverage by <.01%.
The diff coverage is 53.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #2278      +/-   ##
==========================================
- Coverage    70.11%   70.1%   -0.01%     
==========================================
  Files          689     689              
  Lines        50800   50815      +15     
==========================================
+ Hits         35617   35626       +9     
- Misses       15183   15189       +6
Impacted Files Coverage Δ
src/ripple/app/misc/ValidatorList.h 98.27% <ø> (ø) ⬆️
src/ripple/app/misc/ValidatorSite.h 100% <ø> (ø) ⬆️
src/ripple/app/misc/impl/ValidatorList.cpp 81.22% <53.33%> (-2.12%) ⬇️
src/ripple/app/main/Application.cpp 60.42% <0%> (-0.12%) ⬇️
src/ripple/protocol/impl/STVar.cpp 88.31% <0%> (+2.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cafe18c...bce9bca. Read the comment docs.

@bachase

👍 Can consider adding a test where the published list's validator manifest is older than one already available.

https://github.com/bachase/rippled/tree/bc-serve-manifests rebases #2242 on this changeset and adds the fold commit to include the current signing_keys in the validators RPC response.

@mellery451

👍

@bachase bachase merged commit bce9bca into ripple:develop Nov 30, 2017

2 of 5 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
codecov/patch 53.33% of diff hit (target 70.11%)
Details
codecov/project 70.1% (-0.01%) compared to cafe18c
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
default Build finished.
Details
@bachase

This comment has been minimized.

Show comment
Hide comment
@bachase

bachase Nov 30, 2017

Contributor

Merged as bce9bca

Contributor

bachase commented Nov 30, 2017

Merged as bce9bca

@wilsonianb wilsonianb deleted the wilsonianb:serve-manifests branch May 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment