Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force boost static linking for macos builds #2334

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@mellery451
Copy link
Contributor

commented Jan 17, 2018

No description provided.

@seelabs
Copy link
Contributor

left a comment

👍 code looks good; tested both static and non-static builds on linux.

@ripplelabs-jenkins

This comment has been minimized.

Copy link
Collaborator

commented on 980c929 Jan 17, 2018

Jenkins Build Summary

Built from this commit

Built at 20180117 - 20:12:37

Test Results

Build Type Result Status
clang.debug.unity 975 cases, 0 failed, t: 387s PASS
coverage 975 cases, 0 failed, t: 613s PASS
clang.debug.nounity 973 cases, 0 failed, t: 324s PASS
gcc.debug.unity 975 cases, 0 failed, t: 431s PASS
gcc.debug.nounity 973 cases, 0 failed, t: 565s PASS
clang.release.unity 974 cases, 0 failed, t: 467s PASS
gcc.release.unity 974 cases, 0 failed, t: 505s PASS
@ripplelabs-jenkins

This comment has been minimized.

Copy link
Collaborator

commented Jan 17, 2018

Jenkins Build Summary

Built from this commit

Built at 20180117 - 20:41:07

Test Results

Build Type Result Status
coverage 975 cases, 0 failed, t: 614s PASS
clang.debug.unity 975 cases, 0 failed, t: 383s PASS
gcc.debug.unity 975 cases, 0 failed, t: 431s PASS
clang.debug.nounity 973 cases, 0 failed, t: 717s PASS
gcc.debug.nounity 973 cases, 0 failed, t: 312s PASS
clang.release.unity 974 cases, 0 failed, t: 470s PASS
gcc.release.unity 974 cases, 0 failed, t: 503s PASS
@scottschurr
Copy link
Contributor

left a comment

👍 Looks good to me. I nuked my cmake build trees and did both a unity/release and no-unity/debug cmake build. Both built and linked just fine. Both successfully ran unit tests.

@scottschurr scottschurr added the Passed label Jan 17, 2018

@mellery451 mellery451 closed this Jan 18, 2018

@mellery451 mellery451 deleted the mellery451:mellery-mac-static branch Jan 18, 2018

@scottschurr

This comment has been minimized.

Copy link
Contributor

commented Jan 19, 2018

Incorporated in 0.90.0-b4 as 2a4eac6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.