Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temper excessive warnings about historical shard #3620

Closed
wants to merge 2 commits into from

Conversation

undertome
Copy link
Contributor

High Level Overview of Change

When a node already has historical shards stored, but is subsequently configured to not store historical shards, the shard database produces excessive warnings about the historical shard limit being exceeded. This PR fixes this issue, and also replaces several calls to a Nodestore function with roughly equivalent calls to a DatabaseShardImp function.

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • [ x] Refactor (non-breaking change that only restructures code)

Copy link
Contributor

@miguelportilla miguelportilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@undertome undertome added the Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required. label Oct 20, 2020
@undertome undertome removed the Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required. label Nov 2, 2020
@carlhua carlhua added the Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required. label Nov 18, 2020
@carlhua carlhua added this to In Review in XRPL 1.7 via automation Nov 19, 2020
@carlhua carlhua removed the Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required. label Nov 20, 2020
@nbougalis nbougalis mentioned this pull request Dec 4, 2020
@carlhua carlhua added the Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required. label Dec 4, 2020
XRPL 1.7 automation moved this from In Review to Done Dec 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants