Permalink
Browse files

Fix config and CAPI signing operations

  • Loading branch information...
Daniel Risacher
Daniel Risacher committed Sep 23, 2015
1 parent 1b11aec commit 6645bcf72a9b5e6f69e625c8fdc79da87e8628f7
View
1 capi.c
@@ -5,6 +5,7 @@
#include <windows.h>
#include <Cryptuiapi.h>
#include <ntstatus.h>
#include "capi.h"
#include "ssh.h"
#define SHA1_BYTES 20
Oops, something went wrong.

8 comments on commit 6645bcf

@risacher

This comment has been minimized.

Show comment
Hide comment
@risacher

risacher Sep 23, 2015

Owner

Oh gawd. What did VS2015 do to the whitespace?!?

Owner

risacher replied Sep 23, 2015

Oh gawd. What did VS2015 do to the whitespace?!?

@jdantzler

This comment has been minimized.

Show comment
Hide comment
@jdantzler

jdantzler Sep 23, 2015

Collaborator

Yikes! Well at least you got the CAPI signing operations working now. That is the important thing. Great work.

Collaborator

jdantzler replied Sep 23, 2015

Yikes! Well at least you got the CAPI signing operations working now. That is the important thing. Great work.

@risacher

This comment has been minimized.

Show comment
Hide comment
@risacher

risacher Sep 23, 2015

Owner
Owner

risacher replied Sep 23, 2015

@jdantzler

This comment has been minimized.

Show comment
Hide comment
@jdantzler

jdantzler Sep 23, 2015

Collaborator

Any reason your executables are larger in size than normal? Your compiled PuTTY 0.65 vs mine (2.05MB vs 632KB). Also, the putty application looks different with the buttons and text boxes.
Not a big deal, just curious is all. See attached image for comparison.

putty comparison

Collaborator

jdantzler replied Sep 23, 2015

Any reason your executables are larger in size than normal? Your compiled PuTTY 0.65 vs mine (2.05MB vs 632KB). Also, the putty application looks different with the buttons and text boxes.
Not a big deal, just curious is all. See attached image for comparison.

putty comparison

@risacher

This comment has been minimized.

Show comment
Hide comment
@risacher

risacher Sep 23, 2015

Owner

I believe the executables are larger because I compiled them with all the debugging info included, rather than the "release" configuration. Also, I compiled under Visual Studio 2015, which I'm assuming is responsible for the minor visual differences - it's presumably pulling in slightly different versions of the available GUI libraries.

I intend to recompile in the 'release' configuration tonight and push to the 'executables' folder in the github repo - but it was 0430 local by the time I finished debugging, and as soon as I got something that worked I posted it for the user(s) who reported the issue and went to bed.

Owner

risacher replied Sep 23, 2015

I believe the executables are larger because I compiled them with all the debugging info included, rather than the "release" configuration. Also, I compiled under Visual Studio 2015, which I'm assuming is responsible for the minor visual differences - it's presumably pulling in slightly different versions of the available GUI libraries.

I intend to recompile in the 'release' configuration tonight and push to the 'executables' folder in the github repo - but it was 0430 local by the time I finished debugging, and as soon as I got something that worked I posted it for the user(s) who reported the issue and went to bed.

@alohaug

This comment has been minimized.

Show comment
Hide comment
@alohaug

alohaug Sep 24, 2015

Thanks @risacher .

I found CLI option problem reported in #9 was still reproduced with pagent.exe of 6645bcf on https://risacher.org/putty-cac/testing/ .

alohaug replied Sep 24, 2015

Thanks @risacher .

I found CLI option problem reported in #9 was still reproduced with pagent.exe of 6645bcf on https://risacher.org/putty-cac/testing/ .

@jdantzler

This comment has been minimized.

Show comment
Hide comment
@jdantzler

jdantzler Sep 24, 2015

Collaborator

@alohaug It seems to be working again in the latest release build.

https://risacher.org/putty-cac/testing/Release/pageant.exe

Collaborator

jdantzler replied Sep 24, 2015

@alohaug It seems to be working again in the latest release build.

https://risacher.org/putty-cac/testing/Release/pageant.exe

@alohaug

This comment has been minimized.

Show comment
Hide comment
@alohaug

alohaug Sep 24, 2015

@jdantzler @risacher New binaries works fine again. 👍

alohaug replied Sep 24, 2015

@jdantzler @risacher New binaries works fine again. 👍

Please sign in to comment.