Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop postStateDigest from IRiscZeroVerifier.verify #79

Closed
nategraf opened this issue Apr 24, 2024 · 3 comments
Closed

Drop postStateDigest from IRiscZeroVerifier.verify #79

nategraf opened this issue Apr 24, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@nategraf
Copy link
Contributor

nategraf commented Apr 24, 2024 •
edited by flaub
Loading

Following risc0/risc0#1690, the postStateDigest is now zeroed when exiting with Halt. As a result, we should drop it from the IRiscZeroVerifier.verify function signature.
@nategraf nategraf added the enhancement New feature or request label Apr 24, 2024
@nategraf nategraf self-assigned this Apr 24, 2024
@nategraf
Copy link
Contributor Author

nategraf commented Apr 30, 2024 •
edited
Loading

Need to complete this after with #73

@nategraf nategraf removed their assignment May 2, 2024
@nategraf
Copy link
Contributor Author

nategraf commented May 9, 2024

Blocked on changes to rv32im to reset pc to 0 on Halt

@flaub
Copy link
Member

flaub commented May 9, 2024

I'll try to work on that today and get that landed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@flaub @nategraf