Ensure reproducible builds regardless of build path #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
build path. Upstream commit 12753d2 introduced uses of __FILE__ which may result in the build path getting embedded into the resulting binary. https://reproducible-builds.org/docs/build-path/ Signed-off-by: Vagrant Cascadian <vagrant@reproducible-builds.org>
alistair23
approved these changes
Nov 22, 2021
There was a problem hiding this comment.
Sounds good to me!
OpenSBI prefers patches be submitted to the mailing list for approval though, you can find more details about this here: https://github.com/riscv-software-src/opensbi/blob/master/docs/contributing.md
|
This has been taken care by new sbi_panic() and SBI_ASSERT() support in sbi_console.h |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Upstream commit 12753d2 introduced
uses of FILE which may result in the build path getting embedded
into the resulting binary.
The -ffile-prefix-map argument is available in gcc 8 and clang 10, which can be used to strip out the absolute part of the path from the artifacts the compiler produces.
https://reproducible-builds.org/docs/build-path/
Signed-off-by: Vagrant Cascadian vagrant@reproducible-builds.org