Add halt groups and external triggers.#404
Merged
Merged
Conversation
This allows a group of harts to simultaneously halt when any of them hits a breakpoint, or even when some other event occurs in the system.
| \item A RISC-V hart can be halted when a trigger matches the PC, | ||
| read/write address/data, or an instruction opcode. (Optional) | ||
| \item Harts can be grouped, and harts in the same group will all halt when | ||
| any of them halts. These groups can also react to or notify external |
Collaborator
There was a problem hiding this comment.
"raise"/"cause" external triggers? I don't know what it means to "notify" a trigger.
Contributor
Author
There was a problem hiding this comment.
How about "react to or assert external signals"? (Together with rewriting other uses of trigger in this context to signal.) Trigger inherently implies an input.
| <register name="Debug Module Control and Status 2" short="dmcs2" address="0x32"> | ||
| This register contains DM control and status bits that didn't easily | ||
| fit in \Rdmcontrol and \Rdmstatus, and are only likely to be | ||
| implemented in larger systems. |
Collaborator
There was a problem hiding this comment.
what is a "larger" system... you mean one with many harts?
Contributor
Author
There was a problem hiding this comment.
Systems that are so large they don't mind an extra hundred gates for debug functionality. Is there a better way to say that?
Collaborator
There was a problem hiding this comment.
Why not just say "are optional".
Contributor
Author
There was a problem hiding this comment.
Done.
Megan Wachs (mwachs5)
approved these changes
Dec 4, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows a group of harts to simultaneously halt when any of them
hits a breakpoint, or even when some other event occurs in the system.