Stopcount only applies to hart-local counters.#405
Merged
Conversation
The cycle counter is global across all harts in a core, so shouldn't stop in multi-hart cores. This change is not 100% backwards compatible. A testsuite testing 0.13 might check that cycle stops while halted with stopcount=1, and this change would break that. I think it's compatible enough, however, since halting cycle on a multi-hart core with not all harts halted is even more broken.
Ernie Edgar (ernie-sifive)
approved these changes
Dec 12, 2018
Ernie Edgar (ernie-sifive)
left a comment
Ernie Edgar (ernie-sifive)
left a comment
Collaborator
There was a problem hiding this comment.
The change looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cycle counter is global across all harts in a core, so shouldn't
stop in multi-hart cores.
This change is not 100% backwards compatible. A testsuite testing 0.13
might check that cycle stops while halted with stopcount=1, and this
change would break that.
I think it's compatible enough, however, since halting cycle on a
multi-hart core with not all harts halted is even more broken.
Fixes #388