Conversation
Addresses #409.
| 0: Triggers with action=0 do not match/fire while the hart is in M-mode. | ||
|
|
||
| 1: Triggers do match/fire while the hart is in M-mode. | ||
| 1: Triggers with action=0 do match/fire while the hart is in M-mode. |
Collaborator
There was a problem hiding this comment.
Saying triggers with action=0 fire almost implies that triggers with other actions don't fire. What do you think about a clarifying statement saying that mte has no effect on triggers with action!=0?
Contributor
Author
There was a problem hiding this comment.
How about reverting just the 1 line:
1: Triggers do match/fire while the hart is in M-mode.
Collaborator
There was a problem hiding this comment.
That sounds good and should be unambiguous!
ernie-sifive
approved these changes
Dec 14, 2018
| 0: Triggers with action=0 do not match/fire while the hart is in M-mode. | ||
|
|
||
| 1: Triggers do match/fire while the hart is in M-mode. | ||
| 1: Triggers with action=0 do match/fire while the hart is in M-mode. |
Collaborator
There was a problem hiding this comment.
That sounds good and should be unambiguous!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #409.