Conversation
Fixes #413. This is a pretty important clarification. Is it an erratum?
Collaborator
|
I don't think this is an erratum. Elsewhere in the spec we clearly state that the intention is to halt a hart immediately out of reset before any instructions have executed. |
ernie-sifive
approved these changes
Jan 10, 2019
Collaborator
ernie-sifive
left a comment
ernie-sifive
left a comment
There was a problem hiding this comment.
These changes look good and clarify haltreq behavior.
Contributor
Author
Can you point me where we state that intention? I couldn't find it when I went looking for it, which is why I wrote this clarification. |
Contributor
Author
|
Fixes #416. |
timsifive
added a commit
that referenced
this pull request
Feb 12, 2019
Fixes #413. This is a pretty important clarification. Is it an erratum?
timsifive
added a commit
that referenced
this pull request
Feb 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #413.
This is a pretty important clarification. Is it an erratum?