When extending IR, BYPASS still is all ones.#437
Merged
Conversation
See #436. Does this change need to go in 0.13 as well?
Ernie Edgar (ernie-sifive)
approved these changes
Apr 9, 2019
Ernie Edgar (ernie-sifive)
left a comment
Ernie Edgar (ernie-sifive)
left a comment
Collaborator
There was a problem hiding this comment.
I would say that it's not necessary to update 0.13 for this, but maybe add it if you update 0.13 for something else.
Contributor
Author
|
We shouldn't lump it in with another change. Either this is important enough or it isn't. This feels like a bug since the spec didn't reflect what we intended, and is wrong. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #436. Does this change need to go in 0.13 as well?