Addressing more feedback from Marc Gauthier.#465
Merged
Conversation
Paul Donahue (pdonahue-ventana)
requested changes
Jun 11, 2019
Paul Donahue (pdonahue-ventana)
left a comment
Paul Donahue (pdonahue-ventana)
left a comment
Collaborator
There was a problem hiding this comment.
A few uses of "exception" should be "trap" because (1) they aren't intended to refer to, for instance, floating point exceptions that don't trap and (2) they are intended to include interrupts that do trap (assuming that the debugger didn't disable them with stepie for some reason). See my individual comments.
Co-Authored-By: Paul Donahue <48959409+pdonahue-ventana@users.noreply.github.com>
Co-Authored-By: Paul Donahue <48959409+pdonahue-ventana@users.noreply.github.com>
Co-Authored-By: Paul Donahue <48959409+pdonahue-ventana@users.noreply.github.com>
Co-Authored-By: Paul Donahue <48959409+pdonahue-ventana@users.noreply.github.com>
| instruction executed. | ||
| </field> | ||
| <field name="timing" bits="18" access="R/W" reset="0"> | ||
| <field name="timing" bits="18" access="WARL" reset="0"> |
Collaborator
There was a problem hiding this comment.
If you're going to change this to WARL, why not the rest of the fields in this register? They can only take on certain legal values too.
There was a problem hiding this comment.
Perhaps maskmax is the only field not WARL, because it's not writable.
Contributor
Author
There was a problem hiding this comment.
Good point. I changed almost all of them.
Ernie Edgar (ernie-sifive)
approved these changes
Jul 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://lists.riscv.org/g/tech-debug/message/756