Skip to content

Time may pass before dmactive becomes high.#500

Merged
Tim Newsome (timsifive) merged 2 commits into
masterfrom
dmactive
Nov 22, 2019
Merged

Time may pass before dmactive becomes high.#500
Tim Newsome (timsifive) merged 2 commits into
masterfrom
dmactive

Conversation

@timsifive

Copy link
Copy Markdown
Contributor

This addresses a concern of how the debugger can know when hardware is
ready to be debugged, discussed on the mailing list. subject:"Email
discussion: how can a debugger know when a target is ready for it?"

This addresses a concern of how the debugger can know when hardware is
ready to be debugged, discussed on the mailing list. subject:"Email
discussion: how can a debugger know when a target is ready for it?"
Comment thread xml/dm_registers.xml Outdated
Comment on lines +246 to +247
take a long time to set this bit if it's not currently ready for
debugging to take place.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't really crucial but I find this sentence to be a little less formal than specs normally are (like "long time" and what does it mean for "debugging to take place"). How about something like:
"Hardware may postpone setting this bit until it is in a state that allows further debugger accesses."
or combining with a rewrite of the previous sentence:
"After this bit is written with 1, the bit will continue to be seen by reads as being 0 until the hardware is in the defined post-reset state. Therefore, after writing 1 the debugger should poll \RdmDmcontrol until it observes that it is set."
(because the debugger shouldn't just read it once, it should poll until set)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or "After writing 1, the debugger should poll Dmcontrol until dmactive is high. Hardware may take an arbitrarily long time to initialize and will indicate completion by setting dmactive to 1."

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect.

@timsifive Tim Newsome (timsifive) merged commit c9c286b into master Nov 22, 2019
@timsifive Tim Newsome (timsifive) deleted the dmactive branch November 22, 2019 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants