Halt state may not be preserved across reset.#504
Merged
Conversation
It's not necessary to have this requirement, since there are other mechanisms to ensure harts halt out of reset if that's what the debugger wants. Fixes #357.
| immediately enter Debug Mode (halted state). Otherwise it will execute normally | ||
| (running state). | ||
| immediately enter Debug Mode (halted state). | ||
| If the hart was initially running it will execute normally (running state). |
Collaborator
There was a problem hiding this comment.
Do we need an "otherwise" or "If haltreq and resethaltreq are both clear, then..." before the second part of this?
Contributor
Author
There was a problem hiding this comment.
That's probably better.
Ernie Edgar (ernie-sifive)
approved these changes
Nov 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's not necessary to have this requirement, since there are other
mechanisms to ensure harts halt out of reset if that's what the debugger
wants.
Fixes #357.