Skip to content

Adding version encoding for 0.14 spec.#512

Merged
timsifive merged 2 commits intoriscv:masterfrom
bdwyatt:dm_version_encoding
Feb 13, 2020
Merged

Adding version encoding for 0.14 spec.#512
timsifive merged 2 commits intoriscv:masterfrom
bdwyatt:dm_version_encoding

Conversation

@bdwyatt
Copy link
Collaborator

@bdwyatt bdwyatt commented Jan 16, 2020

I'm of the view that there are sufficient changes in 0.14 to warrant a distinct encoding for the version. This pull request simply adds that encoding to the spec.

@timsifive
Copy link
Contributor

The goal was to make .14 backwards/forwards compatible with 0.13. There have been a few changes where that isn't the case, but they deal with corner cases that I don't expect anybody to notice. This would be an intentionally incompatible change. I'm not really against it, since all that would have to be changed is debuggers to recognize the new number. But I think we should think about whether we want this.

@bdwyatt
Copy link
Collaborator Author

bdwyatt commented Jan 17, 2020

Yeah, I probably should have raised this as an issue for discussion first, but the goal of this is just to put it on the radar and make sure we consider it before finalizing 0.14.

@rbohn
Copy link

rbohn commented Jan 17, 2020

There are changes since 0.13 that are backwards incompatible. The specific case I have in mind is #507 . This isn't theoretical: following the old FdmSbcsSbautoincrement text to the letter is incompatible with some versions of commercial debugger software available today. The debugger software needs to be able to discover which behavior it is potentially dealing with.

Copy link
Contributor

@timsifive timsifive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per discussion in today's call, let's merge this. However, this change has tabs in a file that otherwise only uses spaces. Can you fix that?

@bdwyatt bdwyatt requested a review from timsifive February 12, 2020 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants