Skip to content

Add abstractcs.relaxedpriv#536

Merged
timsifive merged 7 commits intoriscv:masterfrom
pdonahue-ventana:relaxedpriv
Aug 5, 2020
Merged

Add abstractcs.relaxedpriv#536
timsifive merged 7 commits intoriscv:masterfrom
pdonahue-ventana:relaxedpriv

Conversation

@pdonahue-ventana
Copy link
Copy Markdown
Collaborator

New dmcontrol.relaxedpriv bit as discussed in https://lists.riscv.org/g/tech-debug/topic/75549024

@ernie-sifive
Copy link
Copy Markdown
Collaborator

May I suggest that this new control bit be put in abstractcs instead of dmcontrol since it specifically applies to that function? This will also solve the problem of what happens if you change the bit during execution of an abstract command or the program buffer (abstractcs.cmderr will be set to 1).

@pdonahue-ventana
Copy link
Copy Markdown
Collaborator Author

May I suggest that this new control bit be put in abstractcs instead of dmcontrol

Good point. I'll make changes (probably tomorrow) to move it to abstractcs[11].

@pdonahue-ventana pdonahue-ventana changed the title Add dmcontrol.relaxedpriv Add abstractcs.relaxedpriv Jul 31, 2020
@pdonahue-ventana
Copy link
Copy Markdown
Collaborator Author

Take a look now. I changed the name of this PR, moved the bit to abstractcs, and fixed the LaTeX error.

Copy link
Copy Markdown
Collaborator

@ernie-sifive ernie-sifive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Paul. Looks good to me!

@ernie-sifive ernie-sifive requested a review from timsifive July 31, 2020 14:47
Copy link
Copy Markdown
Contributor

@timsifive timsifive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@timsifive timsifive merged commit 0570f14 into riscv:master Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants