Merged
Conversation
Clarify that registers are "accessible" in specified modes, not just "writable" Prohibit hcontext alias when the H extension isn't supported since this is in the CSR address space that's normally just for hypervisor.
Collaborator
ernie-sifive
left a comment
ernie-sifive
left a comment
There was a problem hiding this comment.
Thanks for doing this! I have a few minor comments.
Co-authored-by: Ernie Edgar <43148441+ernie-sifive@users.noreply.github.com>
Remove comments about future H mode support
Clarify in various places that enables are for "S/HS" instead of just "S" mode.
timsifive
suggested changes
Sep 16, 2020
Contributor
timsifive
left a comment
timsifive
left a comment
There was a problem hiding this comment.
Looks good overall, just one comment.
Thanks again for taking this on.
timsifive
approved these changes
Sep 21, 2020
Contributor
timsifive
left a comment
timsifive
left a comment
There was a problem hiding this comment.
Looks good. Thank you. I'll merge this tomorrow unless there are more comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for the H extension. Also: