Add support for the A extension#561
Merged
Tim Newsome (timsifive) merged 4 commits intoOct 30, 2020
Merged
Conversation
Tim Newsome (timsifive)
suggested changes
Oct 28, 2020
Tim Newsome (timsifive)
left a comment
Contributor
There was a problem hiding this comment.
Content looks good to me. I just have some formatting feedback.
Tim Newsome (timsifive)
approved these changes
Oct 29, 2020
Tim Newsome (timsifive)
left a comment
Contributor
There was a problem hiding this comment.
Thanks. github says there's a conflict in the PDF. Can you resolve that, so I can merge?
I think the simplest way is to merge master into this branch, resolving the PDF conflict in favor of master. But if you want to rewrite history so you never modified the PDF file in the first place that's also fine.
Collaborator
Author
|
Sorry. I always build the file to make sure there are no errors, to eyeball it, etc. I accidentally put it in one of the commits. I'll fix it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to https://lists.riscv.org/g/tech-debug/topic/76138908
I tried to provide flexibility for implementations that: