Skip to content

Add support for the A extension#561

Merged
Tim Newsome (timsifive) merged 4 commits into
riscv:masterfrom
pdonahue-ventana:a-extension-support
Oct 30, 2020
Merged

Add support for the A extension#561
Tim Newsome (timsifive) merged 4 commits into
riscv:masterfrom
pdonahue-ventana:a-extension-support

Conversation

@pdonahue-ventana

Copy link
Copy Markdown
Collaborator

Followup to https://lists.riscv.org/g/tech-debug/topic/76138908

I tried to provide flexibility for implementations that:

  • don't return data on AMOs to x0 (and, for similar reasons, for loads to x0)
  • have different ways of handling failing SC instructions
  • do store data comparison in various places with relation to where AMOs are performed

Comment thread xml/hwbp_registers.xml Outdated

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@timsifive Tim Newsome (timsifive) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content looks good to me. I just have some formatting feedback.

Comment thread xml/hwbp_registers.xml Outdated
Comment thread xml/hwbp_registers.xml Outdated
Comment thread xml/hwbp_registers.xml
Comment thread xml/hwbp_registers.xml Outdated
Comment thread xml/hwbp_registers.xml Outdated

@timsifive Tim Newsome (timsifive) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. github says there's a conflict in the PDF. Can you resolve that, so I can merge?

I think the simplest way is to merge master into this branch, resolving the PDF conflict in favor of master. But if you want to rewrite history so you never modified the PDF file in the first place that's also fine.

@pdonahue-ventana

Copy link
Copy Markdown
Collaborator Author

Sorry. I always build the file to make sure there are no errors, to eyeball it, etc. I accidentally put it in one of the commits. I'll fix it.

@timsifive
Tim Newsome (timsifive) merged commit 971d0aa into riscv:master Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants