require polling of dmactive low as well as dmactive high transitions - #566
Merged
Tim Newsome (timsifive) merged 1 commit intoOct 16, 2020
Merged
Conversation
Ernie Edgar (ernie-sifive)
approved these changes
Oct 14, 2020
Ernie Edgar (ernie-sifive)
left a comment
Ernie Edgar (ernie-sifive)
left a comment
Collaborator
There was a problem hiding this comment.
Thanks, this change looks good to me!
Tim Newsome (timsifive)
approved these changes
Oct 14, 2020
Tim Newsome (timsifive)
left a comment
Tim Newsome (timsifive)
left a comment
Contributor
There was a problem hiding this comment.
Looks good. I'll merge it tomorrow unless there are more comments.
This change is backwards-incompatible, but it's a trivial change for debuggers that allows some hardware implementations to be simplified a little.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This proposed spec change would allow a DM time to deactivate gracefully by requiring a debugger to poll after writing 0 to dmcontrol.dmactive. Currently the spec only states that a debugger should poll after writing 1 to this bit.
Prior discussion can be found in my post to the tech-debug mailing list on 2020.10.13, Subject "How to reliably inform debugger of completion of DM inactivation?".