Explain how to simply write any trigger.#598
Merged
Merged
Conversation
Addresses #573. This new requirement only changes hardware with writable types. Even there it is trivial to implement as long as types 2 or 6 are supported, and those types become selected when 0 is written.
Ernie Edgar (ernie-sifive)
approved these changes
Nov 13, 2020
Collaborator
Ernie Edgar (ernie-sifive)
left a comment
Ernie Edgar (ernie-sifive)
left a comment
There was a problem hiding this comment.
This looks good!
Paul Donahue (pdonahue-ventana)
approved these changes
Nov 14, 2020
Collaborator
Paul Donahue (pdonahue-ventana)
left a comment
Paul Donahue (pdonahue-ventana)
left a comment
There was a problem hiding this comment.
This seems easy enough for hardware to support and it provides crucial information for debugger writers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #573.
This new requirement only changes hardware with writable types. Even
there it is trivial to implement as long as types 2 or 6 are supported,
and those types become selected when 0 is written.