Use trigger type 15 to indicate disabled.#721
Merged
Conversation
Also clarify tdata2/tdata3 behavior when a trigger is disabled. Add a paragraph about context restoring triggers.
Tim Newsome (timsifive)
requested a review
from Paul Donahue (pdonahue-ventana)
Contributor
Author
|
Hopefully clarifies #718. |
Collaborator
|
Did you figure out what type=15 is for? |
Contributor
Author
|
I just dug through my email. I invented type 15 at the very beginning of
tdata1.type (June 15, 2016). I really don't remember why.
Maybe it's to represent that the trigger is currently owned by the external
debugger, when the target tries to read the register? But the dmode bit
already shows that.
Tim
…On Thu, Apr 21, 2022 at 2:35 PM Paul Donahue ***@***.***> wrote:
Did you figure out what type=15 is for?
—
Reply to this email directly, view it on GitHub
<#721 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD3AP3LRL6OVHQNIHNQI5ETVGHC3VANCNFSM5UACCAIA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Nobody can remember why a trigger might be unavailable, or imagine what that even means.
Paul Donahue (pdonahue-ventana)
requested changes
Apr 25, 2022
Paul Donahue (pdonahue-ventana)
left a comment
Paul Donahue (pdonahue-ventana)
left a comment
Collaborator
There was a problem hiding this comment.
This looks good overall. Just a formatting issue.
Co-authored-by: Paul Donahue <48959409+pdonahue-ventana@users.noreply.github.com>
Paul Donahue (pdonahue-ventana)
approved these changes
Apr 26, 2022
Tim Newsome (timsifive)
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also clarify tdata2/tdata3 behavior when a trigger is disabled.
Add a paragraph about context restoring triggers.