Tighten up language around icount matching.#722
Merged
Conversation
Specifically, now icount triggers on M-Mode only systems are more useful, because the count might not decrement while in an interrupt handler. See 2022 email discussion subject:"trigger questions"
Tim Newsome (timsifive)
requested a review
from Paul Donahue (pdonahue-ventana)
Collaborator
|
I think that this looks like the right approach. It's technically not backward-compatible with the earlier stable spec. Should that be mentioned in section 1.2.1.5 (incompatible changes during 1.0 stable)? |
1 similar comment
Collaborator
|
I think that this looks like the right approach. It's technically not backward-compatible with the earlier stable spec. Should that be mentioned in section 1.2.1.5 (incompatible changes during 1.0 stable)? |
Contributor
Author
Done. Thanks. |
Paul Donahue (pdonahue-ventana)
approved these changes
May 10, 2022
Collaborator
Paul Donahue (pdonahue-ventana)
left a comment
Paul Donahue (pdonahue-ventana)
left a comment
There was a problem hiding this comment.
Cool.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specifically, now icount triggers on M-Mode only systems are more
useful, because the count might not decrement while in an interrupt
handler.
See 2022 email discussion subject:"trigger questions"