Disambiguate the use of the term "reserved" for HINT instructions - #990
Closed
Alex Bradbury (asb) wants to merge 1 commit into
Closed
Disambiguate the use of the term "reserved" for HINT instructions#990Alex Bradbury (asb) wants to merge 1 commit into
Alex Bradbury (asb) wants to merge 1 commit into
Conversation
As was raised in riscv#300, the overloaded use of the term "reserved" when listing HINT encodings is potentially confusing. As clarified in that thread, these encodings are "reserved" in the intuitive English language meaning of the word, but are _not_ part of the "reserved instruction-set category" as defined in the section 1.3 introduction and further elaborated in section 2.2 "Base Instruction Formats" (which notes how platforms can choose to raise an illegal-instruction exception for reserved instruction encodings).
Contributor
Author
|
Friendly ping on this as it's been a couple of weeks. |
Member
|
Maybe we should just avoid use of the word "reserved" in this paragraph and in the tables, and instead use the word "designated". What do you think Alex Bradbury (@asb) Krste Asanovic (@kasanovic)? |
Alex Bradbury (asb)
added a commit
to asb/riscv-isa-manual
that referenced
this pull request
Mar 29, 2023
The term "reserved" could be ambiguous, as it might be understood to refer to the "reserved instruction-set category" as defined in the section 1.3 instruction and further elaborated in section 2.2 "Base Instruction Formats". Avoid this potential confusion by using "designated" instead, which also matches the terminology used for HINT encodings intended for custom use. This is an alternative to riscv#990.
Contributor
Author
|
That's a good idea, especially as we already say "Designated for custom use" already. I've submitted #1001 as an alternative PR using that approach. |
Andrew Waterman (aswaterman)
pushed a commit
that referenced
this pull request
Mar 29, 2023
…#1001) The term "reserved" could be ambiguous, as it might be understood to refer to the "reserved instruction-set category" as defined in the section 1.3 instruction and further elaborated in section 2.2 "Base Instruction Formats". Avoid this potential confusion by using "designated" instead, which also matches the terminology used for HINT encodings intended for custom use. This is an alternative to #990.
Member
|
Superseded by #1001 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As was raised in #300, the overloaded use of the term "reserved" when listing HINT encodings is potentially confusing. As clarified in that thread, these encodings are "reserved" in the intuitive English language meaning of the word, but are not part of the "reserved instruction-set category" as defined in the section 1.3 introduction and further elaborated in section 2.2 "Base Instruction Formats" (which notes how platforms can choose to raise an illegal-instruction exception for reserved instruction encodings).