Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added placeholder to the "connect with me" page #47

Closed
wants to merge 2 commits into from

Conversation

thomaslian
Copy link
Contributor

A placeholder was added to the TextArea in the "connect with me" page.
Fixes #45

Thomas Oedegaard and others added 2 commits October 7, 2020 21:41
Added placeholder to the to the "connect with me" page
@thomaslian thomaslian changed the title Added placeholder to the to the "connect with me" page Added placeholder to the "connect with me" page Oct 7, 2020
@rishavanand
Copy link
Owner

Hey @thomaslian,
Thanks a lot. I really liked your idea of using labels. Could you change the placeholder to a label because I feel it makes more sense? In the case of placeholders, after users fill up a social field, the placeholder is gone and they can get confused on which one to edit.

@thomaslian
Copy link
Contributor Author

@rishavanand I totally agree, will make a new PR soon! :)

@rishavanand
Copy link
Owner

perfect @thomaslian, btw you can push new commits to your repo and this PR will be updated automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants