Skip to content

feat(storage): support s3fifo for block cache - #16208

Merged
MrCroxx merged 1 commit into
mainfrom
xx/s3fifo
Apr 9, 2024
Merged

feat(storage): support s3fifo for block cache#16208
MrCroxx merged 1 commit into
mainfrom
xx/s3fifo

Conversation

@MrCroxx

@MrCroxx MrCroxx commented Apr 9, 2024

Copy link
Copy Markdown
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

foyer-rs/foyer#303 (comment)

The s3fifo eviction policy (Without ghost queue, maybe just fifo with reinsertion?) shows a good hit ratio among others. Let's try it with RW.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Signed-off-by: MrCroxx <mrcroxx@outlook.com>
@MrCroxx MrCroxx self-assigned this Apr 9, 2024
@MrCroxx
MrCroxx requested a review from a team as a code owner April 9, 2024 05:45
@MrCroxx
MrCroxx requested review from Little-Wallace and hzxa21 April 9, 2024 05:46
@github-actions github-actions Bot added the type/feature Type: New feature. label Apr 9, 2024

@hzxa21 hzxa21 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Look forward to the result!

@MrCroxx
MrCroxx enabled auto-merge April 9, 2024 06:04
@MrCroxx
MrCroxx added this pull request to the merge queue Apr 9, 2024
Merged via the queue into main with commit 21bea68 Apr 9, 2024
@MrCroxx
MrCroxx deleted the xx/s3fifo branch April 9, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type/feature Type: New feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants