Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stream): support sum/min/max over interval type in streaming query #5105

Merged
merged 4 commits into from Sep 5, 2022

Conversation

TennyZhuang
Copy link
Collaborator

@TennyZhuang TennyZhuang commented Sep 5, 2022

Signed-off-by: TennyZhuang zty0826@gmail.com

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

Please check the related issue and slt file.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

If your pull request contains user-facing changes, please specify the types of the changes, and create a release note. Otherwise, please feel free to remove this section.

Types of user-facing changes

Please keep the types that apply to your changes, and remove those that do not apply.

  • SQL commands, functions, and operators

Release note

  • support sum/min/max over interval type in streaming query

Refer to a related PR or issue link (optional)

#4508

Signed-off-by: TennyZhuang <zty0826@gmail.com>
Signed-off-by: TennyZhuang <zty0826@gmail.com>
@TennyZhuang TennyZhuang added the mergify/can-merge Indicates that the PR can be added to the merge queue label Sep 5, 2022
@codecov
Copy link

codecov bot commented Sep 5, 2022

Codecov Report

Merging #5105 (06ba673) into main (e1cacf0) will increase coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5105      +/-   ##
==========================================
+ Coverage   74.24%   74.31%   +0.07%     
==========================================
  Files         882      884       +2     
  Lines      134937   135859     +922     
==========================================
+ Hits       100182   100966     +784     
- Misses      34755    34893     +138     
Flag Coverage Δ
rust 74.31% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/batch/src/error.rs 0.00% <ø> (ø)
src/batch/src/executor/generic_exchange.rs 41.52% <ø> (+0.14%) ⬆️
src/batch/src/executor/join/hash_join.rs 95.36% <ø> (ø)
src/batch/src/executor/join/lookup_join.rs 57.28% <ø> (+1.12%) ⬆️
src/batch/src/executor/monitor/stats.rs 66.01% <ø> (-8.99%) ⬇️
src/batch/src/executor/row_seq_scan.rs 17.67% <ø> (+0.66%) ⬆️
src/common/src/config.rs 64.46% <ø> (+0.29%) ⬆️
src/common/src/hash/key.rs 84.49% <ø> (-1.62%) ⬇️
src/common/src/types/interval.rs 81.33% <ø> (-1.18%) ⬇️
src/compute/src/server.rs 0.00% <ø> (ø)
... and 102 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mergify mergify bot merged commit 372ef5a into main Sep 5, 2022
@mergify mergify bot deleted the feat/stream-sum-interval branch September 5, 2022 10:01
@hengm3467 hengm3467 added the user-facing-changes Contains changes that are visible to users label Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergify/can-merge Indicates that the PR can be added to the merge queue type/feature user-facing-changes Contains changes that are visible to users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants