feat(risedev): add check-udeps
#7836
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`cargo udeps` (which uses `cargo check` internally) is slower but more accurate than `cargo machete` (which uses `ripgrep` internallly) to check unused dependencies. Actually `cargo machete` is good enough, but it doesn't support excluding packages, so it doesn't work well with `workspace-hack` and requires some manual work. So I'd like to a script using `cargo-udeps` for future usage.
xxchan
force-pushed
the
xxchan/external-salamander
branch
from
e8a83c4 to
3967274
Compare
Codecov Report
@@ Coverage Diff @@
## main #7836 +/- ##
==========================================
- Coverage 71.74% 71.73% -0.01%
==========================================
Files 1109 1109
Lines 176822 176822
==========================================
- Hits 126856 126848 -8
- Misses 49966 49974 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
TennyZhuang
approved these changes
Feb 11, 2023
BugenZhao
reviewed
Feb 11, 2023
src/common/Cargo.toml
Outdated
| @@ -10,6 +10,9 @@ repository = { workspace = true } | |||
| [package.metadata.cargo-machete] | |||
| ignored = ["workspace-config", "workspace-hack", "task_stats_alloc"] | |||
|
|
|||
| [package.metadata.cargo-udeps.ignore] | |||
| normal = ["workspace-config", "workspace-hack", "task_stats_alloc"] | |||
There was a problem hiding this comment.
There should be no dependency on workspace-config and task_stats_alloc for library crates. 🤔 Maybe we only add them to the ignored list of cmd and cmd_all?
There was a problem hiding this comment.
Ok, such a lazy boy I am 🫣
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
cargo udeps(which usescargo checkinternally) is slower but more accurate thancargo machete(which usesripgrepinternallly) to check unused dependencies.Actually
cargo macheteis good enough, but it doesn't support excluding packages, so it doesn't work well withworkspace-hackand requires some manual work. So I'd like to a script usingcargo-udepsfor future usage.