Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 3 things #243

Merged
merged 3 commits into from Feb 3, 2021
Merged

Conversation

harbingerofme
Copy link
Collaborator

  • make release builds actually build release
    • please just use the release configuration
  • yeet unused playerapi
    • this could confuse people into thinking we had something here
  • remove 25 times multiplier on interactible credit
    • seems like old testing code

@tristanmcpherson
Copy link
Member

Hmm wow, release was debug? That's disappointing.

@tristanmcpherson tristanmcpherson merged commit 7c95a43 into risk-of-thunder:master Feb 3, 2021
@xiaoxiao921
Copy link
Member

Hmm wow, release was debug? That's disappointing.

I rapidly investigated this with Rein and it was only the case since October 2020 3df0d59#diff-6b875d621bf64ce8fae023380eb9f7e694fb8f9668a9e6cd337daeba3e65c6fd

So it never seen a public release on thunderstore

Also it would need some more exact testing but we are betting that the mono jit actually doesnt do much difference with the release/debug flag in term of speed.

@harbingerofme
Copy link
Collaborator Author

Changes where the output folder for release is though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants