RecalculateStatsAPI: Shield Documentation Fix + New Crit Damage Modifier #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The summary comments on shield modifiers were not taking into account shieldMultAdd due to previous forgetfulness both shield modifiers now mention the correct formula.
StatHookEventArgs now includes critDamageAdd which is directly added to the damage multiplier for a character's critical hits.
harbingerofme
approved these changes
Mar 5, 2022
Renamed critDamageAdd to critDamageMultAdd to be more descriptive. Removed extraneous IL match.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a crit damage modifier to RecalculateStatsAPI,since the newest update moved the relevant values from OnHit to the Body.
Also includes a quick fix to the documentation/summary comments on the shield modifiers, since they previously lacked a correct formula which has caused at least one case of someone misidentifying what shieldMultAdd does, my bad for missing that one last time.