ArtifactCode fix, ContentLogging fix #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've decided to make a change to the PrefabAPI, mainly changing the utility method "IsPrefabHashed" from internal to public. This can be used for Libraries that add prefabs to the networkIdentity array of content packs, making sure the prefab is not from PrefabAPI first before adding it to the array of networked prefabs |
tristanmcpherson
approved these changes
Mar 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes 2 issues.
1- Fixes issue #360, where the ArtifactCode's Vector3 rows where badly implemented.
2- Issue with how R2API logs the content of ContentPacks added to it, It'll no longer Log content multiple times.