Update director api. Update game build check #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove build param for submodules as it is basically unused
|
ILY ideath, especially the final commit of mapping the enum to sceneDefs, that'll save me a LOT of headache on future projects <3 |
Nebby1999
pushed a commit
to Nebby1999/R2API
that referenced
this pull request
Mar 26, 2022
* code style * correct log level for tests * add new vanilla stage entries to enum * move them to folder (not changing namespace) * add new vanilla stage entries to switch case. closes risk-of-thunder#355 * remove extra spaces * better organization for the test project * ILLine is now part of the RoR2BepInExPack * ThrowIfStringIsNullOrWhiteSpace string util * IsSameOrSubclassOf * bump gamelibs * proper game build id remove build param for submodules as it is basically unused * this api is entirely covered by DirectorAPI * DirectorAPI update for SOTV * Some tests for DirectorAPI through console commands * add prefab dump code * Update MonsterNames and InteractableNames * add / enhance back support for old monster families * test for monster families * Add mapping of vanilla stages to scene defs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update DirectorAPI to work for current game patch:
DccsPoolwhich is an extra wrapper aroundDirectorCardCategorySelection(DCCS) by using categories (DccsPool.Category[]), aCategoryis weighted for random selection. ACategoryusually have multiplePoolEntryavailable, ones that are always included in the pool are inalwaysIncluded, some are included only if some conditions are met (if user has game DLC for example), and some others are included if none of the aforementioned conditions were met. APoolEntryis weighted for random selection. APoolEntryholds a DCCS.MonsterActions) a bit harder to use. I tried to alleviate this problem by adding tests so that modders can have them as reference as well as adding a lot of documentation, and also making sure that the existingHelpersmethods are covering most if not all edge cases.This PR also changes how the game build is checked, now uses UnityEngine
Application.versionwhich should allow the check to also work for the EGS game release.Due to the nature of game modding, added a new form of tests which are different than the ones that are fired automatically when the test plugin is loaded into the appdomain. They are under the form of console commands, they can enabled and disabled on the fly for allow quick tests on some features which require multiple game systems to be in use. (Like the Director ones)