Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #370.
ItemAPI no longer checks if the pickup model prefab contains the ItemDisplay component, as in reality that prefab does not require said component, but instead checks the followerPrefab for the rules in the item/equipment's ItemDisplayDictionary.
The ItemDisplayDictionary now has a Validation method, the validation method does not prohibit the addition of a new item/equipment, instead, it's sole purpose is to ensure the Dictionary has valid ItemDisplayRules, the validation method logs the faulty rules using a string builder, which is later logged into the console using R2API.Logger.DebugLog().
The validator looks for:
ItemDisplayRules where the follower prefab is null
ItemDisplayRules where the follower prefab is not null, but does not have an ItemDisplay component
ItemDisplayRules where the follower prefab is not null, has an ItemDisplay Component, but said component's RendererInfos is empty.