Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EliteAPI and bug fix DirectorAPI #372

Merged
merged 7 commits into from Mar 29, 2022

Conversation

xiaoxiao921
Copy link
Member

  • Fix EliteAPI : Was not working anymore because we are calling the CombatDirector.Init and it fill the arrays with null references since we are not early loading the game content anymore, the easy fix is to early load those specific defs which makes the whole thing work again, this is not proper and ideally everything should probably happen inside a IContentPackProvider, I added a todo comment which talks about this a bit more.
  • Add a test to verify if the EliteAPI works or not.
  • Fix a null ref that could happen with old stages with DirectorAPI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants