Marked UnlockableAPI as Obsolete #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason behind these changes is due to the game's 1.2.3 release, which allows us modders to properly use the RegisterAchievement attribute on top of BaseAchievement inheriting classes.
The attribute itself in the game takes care of the registering of AchievementDefs and tying said Achievements to UnlockableDefs, as such, UnlockableAPI has become overall obsolete as the game now provides all the necesary means of registering UnlockableDefs, AchievementDefs and tying Achievements to Unlockables.
Each surface level type of unlockableAPI has been marked obsolete with the following message:
The patch 1.2.3 for RoR2 has made UnlockableAPI's methods and implementations redundant
From now on use the Game's "RegisterAchievement" attribute on top of baseAchievement inheriting classes to register AchievementDefs and tying them to their respective UnlockableDefs
UnlockableAPI will be removed on the next major RoR2 release
tristanmcpherson
approved these changes
Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason behind these changes is due to the game's 1.2.3 release, which allows us modders to properly use the RegisterAchievement attribute on top of BaseAchievement inheriting classes.
The attribute itself in the game takes care of the registering of AchievementDefs and tying said Achievements to UnlockableDefs, as such, UnlockableAPI has become overall obsolete as the game now provides all the necesary means of registering UnlockableDefs, AchievementDefs and tying Achievements to Unlockables.
Each surface level type of unlockableAPI has been marked obsolete with the following message: