Fix custom achievements #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest game patch changed the method r2api was hooking for custom achievements.
The method change made two issues appear:
It can easily throw and stop its execution because it uses GetTypes without handling reflection load exceptions.
So I made a fix in the RoR2Bepinexpack, but because I didnt want to bother IL Hooking it, I totally replaced the method.
By doing that it made the r2api hook impossible to work. I didnt realize at first.
I ended up adding a convenient action event in the RoR2Bepinexpack, which is the perfect place for adding custom defs and so on and that r2api now uses.