-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include Docker Compose #62
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments, mainly to move it to a prod config from a dev config.
docker-compose.yml
Outdated
@@ -0,0 +1,18 @@ | |||
version: "2" | |||
services: | |||
mongo: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will need
deploy:
constraints:
- node.labels.db=true
if planning on running our own
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its something like OneRepos config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cause you'll also have to add
volumes:
volumeName:
docker-compose.yml
Outdated
- "27017:27017" | ||
web: | ||
build: | ||
context: . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additionally this is good for dev, but we'll also need an image only one for prod deploys.
docker-compose.yml
Outdated
links: | ||
- mongo | ||
volumes: | ||
- .:/usr/src/app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand that this is a dev config
docker-compose.yml
Outdated
@@ -0,0 +1,18 @@ | |||
version: "2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update to version 3.1
Dockerfile.dev
Outdated
|
||
ADD start.sh . | ||
|
||
RUN chmod +x ./start.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Permissions are preserved and should be maintained in source. So change this outside the build.
Can't believe it, but everything is working with this push. The first workaround that needs to be addressed though, which I would need help by likely both @7imbrook and @khanny17 on figuring out where I'm going wrong is the config.js is not being added to the container correctly. I believe this is because I am working with the local file as context, and not dist/. It's trying to access config.js, but it's not actually there/not being updated correctly. The second issue is high CPU usage... |
I fixed the above issue of the config file. This is fully working, I just need to investigate the CPU issue... |
@7imbrook have you ever encountered com.docker.hyperkit acting up? |
Did you confirm that the high cpu issue is due to docker and not due to gulp devrun? |
This looks good to go, and with this fix should fix the production issue. Once this is merged to master, I can redeploy and test. |
Working on dockerizing the application with compose. Currently facing ~90% cpu from the application imagine when using docker-compose, need to check in with @7imbrook how to resolve before merging. #57